-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust header and footer for text resizing [a11y] #699
Comments
Hi @dhinrichs-scottlogic, I believe I can help with this issue. Would you mind assigning it to me? |
Yes @Kenny4297 , go ahead, I've assigned this issue to you. Thank you so much for contributing! |
@dhinrichs-scottlogic I think I may be missing something here. When I edit any files when running the application, the changes are not shown at all. This goes for the css files as well. The two files in question are the 'MainHeader.tsx' and its CSS counterpart, 'MainHeader.css'. I'm sure it's something stupid. Any assistance would be helpful! |
Hi Kenny, hmm that's a tricky one 🤔 |
I am starting them up separately, the backend and then the frontend. When you are working on it, do the changes occur immediately? How are you running it so that it works when you make changes? |
Yes, changes are showing after I save them. |
Ahh I got it working. Here's what I did differently: I ran only the frontend using 'npm run dev' instead of 'npm run start:ui'. I did not start the backend (since I am only working with css). Now this allows live changes to be shown. Thanks for the help! |
Great to hear! |
@dhinrichs-scottlogic We are likely to run into problems with the header when zooming, as there are a lot of components in there. At some level we might want to move the function buttons (reset, getting started, handbook) into a dropdown menu, remove the button icons, etc, using media queries as @Kenny4297 suggests. I think this requires some more thought before implementing anything. |
I had a quick go locally to see what css rules we'd need to change. Below is what I changed, which are prime candidates for a media query breakpoint. Note that I've only downsized two fonts and then not by much; most changes are adjustments to spacing, while not making things too compacted.
Result: |
Feature Request
Description
Adjust header and footer so that the text can be resized to 200% without losing functionality.
Additional context
This is to fulfil WCAG 1.4.4 Resize Text. https://www.w3.org/WAI/WCAG21/Understanding/resize-text.html
This means it should be possible to increase the font-size to 200% and no content should be cut off or hidden.
implementation details
some ideas for how this can be done:
Screenshots
How it looks currently at 200%
Roughly expected outcome at 100% (no zoom)
Roughly expected outcome at 200%
Acceptance criteria
GIVEN the user uses the app in the full screen browser on a 13" laptop
WHEN the user zooms to 200%
THEN all of the buttons and links of the header and footer are still visible.
The text was updated successfully, but these errors were encountered: