Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip to top/bottom links to chat #686

Closed
dhinrichs-scottlogic opened this issue Dec 19, 2023 · 5 comments · Fixed by #846
Closed

Add skip to top/bottom links to chat #686

dhinrichs-scottlogic opened this issue Dec 19, 2023 · 5 comments · Fixed by #846
Assignees
Labels
accessibility Addresses accessibility concerns frontend Requires work on the frontend should have

Comments

@dhinrichs-scottlogic
Copy link
Contributor

dhinrichs-scottlogic commented Dec 19, 2023

Feature Request

Description

  • Add a "Skip to chat input" skiplink (shows up on tabbing to) Button to the top of the chatbox
  • Add a "Skip to top of chat" skiplink (shows up on tabbing to) Button to the end of the chatbox

Acceptance criteria

GIVEN The the keyboard focus is on the chat input
WHEN the user tabs to the previous element (shift + tab)
THEN the "skip to top of chat" skip link shows up

WHEN the user activates that link (enter)
THEN the keyboard focus jumps to the "skip to chat input" skip link at the top of the chatbox

WHEN the user activates that link (enter)
THEN the keyboard focus jumps to the chat input

WHEN the keyboard focus is not on the skip links
THEN the skip links are not visible

@dhinrichs-scottlogic dhinrichs-scottlogic added accessibility Addresses accessibility concerns enhancement New feature or request good first issue Simple issue triage New tickets to be checked by the maintainers labels Dec 19, 2023
@pmarsh-scottlogic
Copy link
Contributor

alternative might be to add a "skip to chat box" button at the top of the website

@gsproston-scottlogic gsproston-scottlogic added frontend Requires work on the frontend bug Something isn't working question Further information is requested and removed enhancement New feature or request good first issue Simple issue labels Dec 19, 2023
@gsproston-scottlogic
Copy link
Contributor

gsproston-scottlogic commented Dec 19, 2023

Adding a question label as we probably want to define exactly when this should happen, and update the ACs for that.

It'd definitely be good to autofocus on the chat box after refreshing or coming to the app for the first time.
Do we want to focus on the chat box after switching levels?

@gsproston-scottlogic gsproston-scottlogic removed the triage New tickets to be checked by the maintainers label Dec 19, 2023
@dhinrichs-scottlogic
Copy link
Contributor Author

Yes, on second thought, autofocus on the input would mess with the order of content/focus, so that could actually create an accessibility issue. A skip link, and/or ensuring focus is maintained after refresh might be an idea though.
Need to think this through a bit more.

@dhinrichs-scottlogic dhinrichs-scottlogic removed the bug Something isn't working label Dec 20, 2023
@gsproston-scottlogic
Copy link
Contributor

Just noticed this wasn't added to the project board, so it went under the radar. Added now.

@chriswilty
Copy link
Member

@dhinrichs-scottlogic, @pmarsh-scottlogic Is this the issue you were going to look at together, to give more detail on the "Skip To" idea?

@dhinrichs-scottlogic dhinrichs-scottlogic changed the title When closing the overlay, keyboard focus should be on chatbox input element. Add skip link Jan 16, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic changed the title Add skip link Add skip to chat link Jan 16, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic added should have and removed question Further information is requested labels Jan 19, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic changed the title Add skip to chat link [a11y] Add skip to top/bottom links to chat Jan 19, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic changed the title [a11y] Add skip to top/bottom links to chat Add skip to top/bottom links to chat Jan 19, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic self-assigned this Feb 26, 2024
@dhinrichs-scottlogic dhinrichs-scottlogic linked a pull request Feb 27, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Addresses accessibility concerns frontend Requires work on the frontend should have
Projects
None yet
4 participants