Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitattributes file #348

Closed
chriswilty opened this issue Oct 4, 2023 · 1 comment · Fixed by #349 or #403
Closed

Add gitattributes file #348

chriswilty opened this issue Oct 4, 2023 · 1 comment · Fixed by #349 or #403
Assignees

Comments

@chriswilty
Copy link
Member

Currently, when cloning the repo the code is checked out using whatever line-ending is configured in each of our git configs, but prettier is expecting line-ending to be LF.

This means a prettier run can cause a load of errors, and touch a load of files in cleanup, which then disappear after git add, which is likely to be confusing. Aside from that, we don't want a line-endings war, so it makes sense to set our preference in the repo.

If we add a .gitattributes to the repo with this info, then all checkouts will respect that. Problem solved:

* text eol=lf
@chriswilty
Copy link
Member Author

Small problem with font files to address...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants