Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved changes handler causing multiple re-renders #92

Open
OiNutter opened this issue Oct 3, 2021 · 0 comments
Open

Unsaved changes handler causing multiple re-renders #92

OiNutter opened this issue Oct 3, 2021 · 0 comments
Assignees
@ColinEberhardt
Labels
approved Change has been approved by the core team invalid This doesn't seem right

Comments

@OiNutter
Copy link
Contributor

OiNutter commented Oct 3, 2021

The call to setConnections on Line 218 of MainInterface.tsx is causing the results window (and possibly the entire ServerInterface chain) to re-render. It's not breaking anything at the moment but it's obviously not very performant so we'll want to address it when we can.

A possible suggestion could be to store a seperate map of connection id to unsaved changes boolean so we can update that without causing a re-render?
@OiNutter OiNutter added invalid This doesn't seem right approved Change has been approved by the core team labels Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ColinEberhardt ColinEberhardt

Labels
approved Change has been approved by the core team invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OiNutter @ColinEberhardt