Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When there are many tabs open, the tab heading list needs to be scrollable #44

Open
ColinEberhardt opened this issue Aug 5, 2021 · 6 comments
Open

When there are many tabs open, the tab heading list needs to be scrollable #44

ColinEberhardt opened this issue Aug 5, 2021 · 6 comments
Labels
approved Change has been approved by the core team enhancement New feature or request

Comments

@ColinEberhardt
Copy link
Contributor

No description provided.

@ColinEberhardt ColinEberhardt added enhancement New feature or request approved Change has been approved by the core team labels Aug 5, 2021
@OiNutter
Copy link
Contributor

OiNutter commented Aug 5, 2021

Assuming we're talking about server tabs this is kind of implemented. It's not scrolling, it's using the overflow item setting built into a Pivot control. This does seem to be the FluentUI way of dealing with too many items on a Pivot

@ColinEberhardt
Copy link
Contributor Author

Currently if you have lots of tabs open, this happens ...

image

@OiNutter
Copy link
Contributor

OiNutter commented Aug 5, 2021

Hmm, that looks like it's not triggering the overflow items. Can you double check line 124 of MainInterface.tsx please? should say overflowBehaviour="menu"

@OiNutter
Copy link
Contributor

OiNutter commented Sep 7, 2021

Is this still happening?

@ColinEberhardt
Copy link
Contributor Author

Yes, this is still an issue.

@OiNutter
Copy link
Contributor

OiNutter commented Sep 9, 2021

This is very strange, I've literally added a test for this which seems to pass (assuming you can connect to the servers, which is a whole other thing). Are you on Mac, Windows or Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Change has been approved by the core team enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OiNutter @ColinEberhardt