Github username look-up

[sehaswell]

Cross-reference Gitlab users with Github users so that a single user whitelist can be used across both.

This is very dependent on the user info provided by Gitlab for our MRs - can we positively identify users? We can't always assume everyone contributing to an MR is using Gitlab, let alone Github.

[maoo]

This is very dependent on the user info provided by Gitlab for our MRs - can we positively identify users?

Assuming we know the GitLab ID, we can use the (v4) users api, which returns the GitHub ID associated with the user, see below, identities > externalUid . Note that GitHub IDs are not usernames; for example, my GitHub username is maoo, my ID is 327285

Thanks!

[maoo]

@sehaswell @strangerich - any update on this ? Or shall I try to work on a PR? Thanks!

[maoo]

Did some investigation here.

It appears that the current user validation process:

1. Fetches user info via the GitLab /users API - https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/gitlabApi.js#L24
2. User info is matched against the committers list on https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/committerFinder.js#L13 , https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/committerFinder.js#L51 and finally https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/committerFinder.js#L56

In theory, the user profile payload that is filtered on https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/committerFinder.js#L57 should include also the GitHub username, on field c.identities.extern_uid

If that is already the case, the only things left would be:

• Adding a matchGitHubId configuration boolean in .clabot
• Adapting https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/contributionVerifier.js to resolve GitHub IDs, if matchGitHubId is true ; in CURL, which is quite simple to achieve (unauthenticated), for example: curl -s https://api.github.com/users/maoo | grep \"id\" | awk '{print $2}'
• Adding an if (matchGitHubId) statement in https://github.com/ScottLogic/gitlab-cla-bot/blob/master/src/committerFinder.js#L57 that filters out all entries where c.identities.extern_uid is not part of the known list of contributors

@strangerich @sehaswell - any thoughts, before I embark in this coding adventure? 😄