Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Number(...) rounding errors #81

Open
ryanggrey opened this issue Jul 7, 2017 · 0 comments
Open

Fix Number(...) rounding errors #81

ryanggrey opened this issue Jul 7, 2017 · 0 comments
Labels
bug

Comments

@ryanggrey
Copy link
Contributor

We use the Number(...) constructor in a few places. Wrapping a string in the number constructor is going to cause rounding errors for values above Number.MAX_SAFE_INTEGER:
Number("9007199254740991.45") will result in 9007199254740991.
@oriondean oriondean added the bug label Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanggrey @oriondean