Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Layout Hooks #47

Closed
vferraro-scottlogic opened this issue Sep 20, 2023 · 0 comments · Fixed by #58
Closed

Refactor Layout Hooks #47

vferraro-scottlogic opened this issue Sep 20, 2023 · 0 comments · Fixed by #58
Assignees
@vferraro-scottlogic
Milestone
Layout Management

Comments

@vferraro-scottlogic
Copy link

vferraro-scottlogic commented Sep 20, 2023 •
edited
Loading

Background

We currently have 2 different Context Providers around layouts: LayoutManagerProvider and LayoutProvider. LayoutManagerProvider includes state and functionality to manage the layouts and the metadata. LayoutProvider manages the on-screen layout (which hasnt been saved with metadata yet).

Work Required

  • move logic for loading, saving layout to useLayoutManager
  • delete use-layout-conifg

useLayoutManager should include:

  • saveLocation based on env variable
  • logic for loading and saving layouts and temp layout
  • warning layout for errors

See PR for POC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vferraro-scottlogic vferraro-scottlogic

Labels
None yet
Projects
None yet
Milestone
Layout Management
2 participants
@vferraro-scottlogic @cfisher-scottlogic