Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation / Transition performance is very bad #56

Open
kinsi55 opened this issue Dec 3, 2021 · 5 comments
Open

Animation / Transition performance is very bad #56

kinsi55 opened this issue Dec 3, 2021 · 5 comments

Comments

@kinsi55
Copy link

kinsi55 commented Dec 3, 2021

Even on desktop (Firefox) transitions / animations are very sluggish as tho they are implemented with Javascript instead of CSS (I really hope they are not). This is probably only worse on Mobile.

This is very noticable when, for example, loading a profile, which runs at like 10-20 FPS but isnt exclusive to just that.

out.mp4
@kinsi55 kinsi55 changed the title Animation / Transtion performance is very bad Animation / Transition performance is very bad Dec 3, 2021
@byhemechi
Copy link
Collaborator

byhemechi commented Dec 3, 2021

I can't reproduce, do you think you could send a screen recording?

Edit: whoops, video didn't load the first go, all good

@kinsi55
Copy link
Author

kinsi55 commented Dec 3, 2021

It seems to be Firefox specific (Or Chrome on Mobile because less performance). I tried it in Chromium Edge and it seems fine there.

@byhemechi
Copy link
Collaborator

I'm thinking this is a reflow issue, I'll investigate moving to GPU transforms when I get home

@kinsi55
Copy link
Author

kinsi55 commented Dec 3, 2021

Seems to be the case, I profiled it and a ton of time is spent in Layout.

grafik

That being said, I have Hardware Acceleration turned off because I have the CPU headroom to not deal with the occasional Issues which that causes, like jittery livestream playback from time to time.

@byhemechi
Copy link
Collaborator

Yeah definitely a reflow issue then.

IIRC it's using sveltekit transitions which I would assume would use transforms not margin.

Maybe something to do with scrolling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants