Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert umbra-js tests to HardHat and add Coverage Report #104

Closed
apbendi opened this issue Mar 8, 2021 · 1 comment · Fixed by #157
Closed

Convert umbra-js tests to HardHat and add Coverage Report #104

apbendi opened this issue Mar 8, 2021 · 1 comment · Fixed by #157
Assignees
@wildmolasses
Labels
dev Developer tooling or devops

Comments

@apbendi
Copy link
Member

apbendi commented Mar 8, 2021

Currently the tests use OZ tests environment and don't produce coverage.
@apbendi apbendi added the dev Developer tooling or devops label Mar 8, 2021
@mds1
Copy link
Collaborator

mds1 commented Apr 1, 2021

Hey @wildmolasses, it seems right now running yarn test from the root causes a failure in an umbra-js test, but running yarn test from within the umbra-js folder does not. See #145 (review)

Do you mind see if that's still the case after doing the Hardhat refactor as part of this issue?

@mds1 mds1 mentioned this issue Apr 1, 2021
Merged
@wildmolasses wildmolasses mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wildmolasses wildmolasses

Labels
dev Developer tooling or devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Umbra js hardhat tests & coverage ScopeLift/umbra-protocol
3 participants
@apbendi @wildmolasses @mds1