Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if loadProvider calls don't return successfully #85

Open
wildmolasses opened this issue Feb 1, 2023 · 0 comments
Open

Error if loadProvider calls don't return successfully #85

wildmolasses opened this issue Feb 1, 2023 · 0 comments

Comments

@wildmolasses
Copy link
Contributor

// Personally think we should error loudly here if feesSerialized not available

If loadProvider returns successfully this will never be not available (just asked railgun) so the right spot to handle this is in railgun.ts. We weren't handling the error case there originally, so worth pulling out into a separate issue? (related to #78 (comment))

Originally posted by @mds1 in #78 (comment)
@wildmolasses wildmolasses changed the title Error if loadProvider doesn't return Error if loadProvider calls don't return successfully Feb 1, 2023
@wildmolasses wildmolasses mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wildmolasses