New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple fee logic from loading the providers, mainly because anywhere this hook is called the providers will be reloaded #80

Open

mds1 opened this issue Jan 31, 2023 · 0 comments

Contributor

mds1 commented Jan 31, 2023

The one improvement we could make here is to decouple this logic from loading the providers, mainly because anywhere this hook is called the providers will be reloaded. The cleanest way to do this may be to some of this to context, but definitely a future improvement.

Originally posted by @alexkeating in #78 (comment)

mds1 mentioned this issue

feat: load shield fees instead of hardcoding it #78

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment