Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notes in results list #67

Closed
ltguillaume opened this issue Sep 6, 2023 · 8 comments
Closed

Include notes in results list #67

ltguillaume opened this issue Sep 6, 2023 · 8 comments

Comments

@ltguillaume
Copy link

Many buckets have manifests that include important notes that may influence whether you'd want to install the application or not.

Here are 5 significant examples, just by looking at the first 10 manifests of the extras bucket:

This is a free 30-day trial version. Please buy a copy of it for furthur evaluation.

Even when you are logging in as 'root', some operations (like service command) require Windows administrator privileges

AltDrag has not been updated since 2015. It may not work as intended under latest Windows versions.
We suggest installing 'extras/altsnap', a maintained fork of AltDrag, for better experience.

This manifest is deprecated and no longer receiving updates. Instead, use the new Android SDK Command-Line tools: android-clt.

AntiMicro is no longer being developed, 2.24 is the final release. See this discussion for information: AntiMicro/antimicro#351. AntiMicroX is a fork that is currently supported: https://github.com/AntiMicroX/antimicrox

As such, I think it would be very useful to have these notes included in the results list on scoop.sh

@rashil2000
Copy link
Member

Hmm, seems like a nice idea. Notes can be hidden by default, and can be shown by clicking an arrow, like this:

These are the manifest notes.

@ltguillaume
Copy link
Author

ltguillaume commented Sep 7, 2023

While that would work, I'm not a fan of hiding the info like that: it prevents looking at the relevant info with a single glance while searching through the results for the most likely candidate to install.

Instead, it might be an idea to allow for two lines to be shown and require from the user to expand the notes block to see the rest.

@gpailler
Copy link
Collaborator

I didn't notice that the notes field was carrying this kind of important information. I will definitely take a look to index the notes and propose a way to display them in the search results

@ltguillaume
Copy link
Author

Great! Thank you so much 😄

@ltguillaume
Copy link
Author

ltguillaume commented Sep 12, 2023

Small "side question" by the way: are the descriptions not updated with every new version of an application? I saw a strange sequence pop up, namely something.,Something (instead of something. Something), which is definitely not in the manifest's description field like that. See https://scoop.sh/#/apps?q=firefox+esr+nl&o=false

@ltguillaume
Copy link
Author

I didn't notice that the notes field was carrying this kind of important information. I will definitely take a look to index the notes and propose a way to display them in the search results

@gpailler Any progress with this? 🙂

gpailler added a commit that referenced this issue May 5, 2024
* #67 Result highlights are returned in an array and should be concatenated
* Lock react-icons version (some Go actions are not available anymore on latest version)
* Fix updated linter rules (import/order)
gpailler added a commit that referenced this issue May 5, 2024
@gpailler
Copy link
Collaborator

gpailler commented May 5, 2024

Thanks for the reminder @ltguillaume ;-)

  • About the commas in the descriptions, it was a nice catch and it's fixed 👍
  • About the notes, it's implemented. If a note field is found in the manifest, it's displayed below the license

@ltguillaume
Copy link
Author

Fantastic, thank you so much! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants