-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with community workarounds to duplicated warnings #5499
Comments
A solution is proposed by #5506, this implements one of two potential replacements for the
An alternate approach is to rewrite the code in iris to avoid the bug described here python/cpython#73858. In particular, this patch of code appears to be resposible for the bug appearing during loading: iris/lib/iris/fileformats/_nc_load_rules/helpers.py Lines 417 to 431 in b6e39d7
It is not guaranteed that all duplications would be a result of code within iris, since some calls to other libraries like import numpy or dask.array.map_blocks also introduce this bug. It may therefore be worthwhile taking both approaches so that:
Finally, it is worth noting that this may end up with us having code that needs to be reverted once this bug is fixed within python, so this ought to be noted by a TODO alongside the code. |
See this gist for a more in depth demonstration of warning duplication https://gist.github.com/stephenworsley/7716fdba4cc634e73454462ad60b3f67 |
The work done in #5536 resolved some of the warning duplication problems, but there remains a significant set of cases which will still cause warning duplication. In particular, this is highlighted by the test data file at It is therefore worthwhile progressing the solution proposed in #5506 which would work around such problematic uses of |
See #5463 for write-up
The text was updated successfully, but these errors were encountered: