-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensealg in solve is ignored #1110
Labels
Comments
Yeah, it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug 🐞
The
sensealg
in solve is ignored, currently it only follows the sensealg defined in the problemLooks like, the sensealg is not in the prob.kwargs, and is ignored in the solve_up call
https://github.com/SciML/DiffEqBase.jl/blob/6b1191f2993f163f09e8b718b28599ac1b3f16e3/src/solve.jl#L993-L1007
https://github.com/SciML/DiffEqBase.jl/blob/6b1191f2993f163f09e8b718b28599ac1b3f16e3/src/solve.jl#L1066-L1083
Expected behavior
allow the sensealg in solve to work
Minimal Reproducible Example 👇
Error & Stacktrace⚠️
A and B gives same result, different from C,
or,
s_sol = solve(s_prob, Tsit5(), sensealg=1)
would actually run without any error messages.Environment (please complete the following information):
using Pkg; Pkg.status()
using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
versioninfo()
Additional context
The last example at https://docs.sciml.ai/SciMLSensitivity/stable/tutorials/direct_sensitivity/ uses the sensealg in the solve call, might be confusing
The text was updated successfully, but these errors were encountered: