EnsembleSummary plot recipe doesn't respect idxs kwarg
#697
Comments
|
I may be misunderstanding |
|
Yep, you're right, just tested it. Must've been a typo, I'll make a PR |
|
Made a PR, but in looking at the code, had a bunch of other thoughts which I'll repost here for posterity since they are more appropriate for an issue than PR comment: " Further considerations or to-dos
"
|
Yes. Both used the
Agreed, it's a missing part of the interface here.
Yeah that's unintentional, it should get fixed.
That's unintentional. I don't use Makie so I'm not 100% how to handle that.
That would be nice. I'm not sure how to do that with recipes though. |
Fix `EnsembleSummary` plot recipe kwarg #697
|
Can this PR be closed now that #700 is merged? |
|
We should get issues on the other points though, those are reasonable asks. |
Doesn't |
The trajectories aren't maintained in the struct EnsembleSummary{T, N, Tt, S, S2, S3, S4, S5} <: AbstractEnsembleSolution{T, N, S}
t::Tt
u::S
v::S2
med::S3
qlow::S4
qhigh::S5
num_monte::Int
elapsedTime::Float64
converged::Bool
endThough allowing subsetting of the trajectories reduced over is definitely low priority compared to the other issues I think. |
Problem
the resulting plot includes all state variables rather than just the first.
No issue with
EnsembleSimulation, justEnsembleSummary.Diagnostic info
Output of
using Pkg; Pkg.status()Output of
using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)Output of
versioninfo()The text was updated successfully, but these errors were encountered: