Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to component parameters #207

Open
bauglir opened this issue Aug 11, 2023 · 3 comments · May be fixed by #214
Open

Add units to component parameters #207

bauglir opened this issue Aug 11, 2023 · 3 comments · May be fixed by #214

Comments

@bauglir
Copy link

bauglir commented Aug 11, 2023

Many components have nice descriptions for parameters and include the corresponding unit information in their comments, e.g. the Resistor or the ConstantPermeance. However, even though this appears to be supported by the @mtkmodel macro, the unit of these parameters is not defined. It would be nice if this additional metadata was made available within the component definitions for introspection.

I'm not sure if the same would be possible for states, but if it is then I imagine that'd be useful as well.

@ven-k ven-k linked a pull request Nov 8, 2023 that will close this issue
@bauglir
Copy link
Author

bauglir commented Nov 9, 2023

Seems related to #90 (this one is newer and hence the duplicate).

@ven-k
Copy link
Member

ven-k commented Jan 24, 2024

#214 is switching to use DynamicQuantities. We need ability to define custom units (like Wb). The foll. PR adds that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants