Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainRules usage isn't tested #86

Open
oxinabox opened this issue Jun 2, 2021 · 1 comment
Open

ChainRules usage isn't tested #86

oxinabox opened this issue Jun 2, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@oxinabox
Copy link
Contributor

oxinabox commented Jun 2, 2021

#84 should have failed as DoesNotExist is no longer defined by ChainRulesCore (renamed to NoTangent)
(fixed in #85)
but there are no actual tests of that directly.
Which makes JuliaDiff/ChainRulesCore.jl#292 kinda pointless.

It should be relatively straight forward to set them up using ChainRulesTestUtils.
@ChrisRackauckas
Copy link
Member

Oh yes, they are all tested directly: https://github.com/PumasAI/DataInterpolations.jl/blob/master/test/derivative_tests.jl, but not through the rrule. That's a silly omission.

@ChrisRackauckas ChrisRackauckas added the good first issue Good for newcomers label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @oxinabox