Fix plot_complexes
#1138
Merged
Fix plot_complexes
#1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
requested changes
Nov 26, 2024
Comment on lines
68
to
72
| for (i,e) in enumerate(edgelist) | ||
| fwd = findall(==(e), edgelist); rev = findall(==(reverse(e)), edgelist) | ||
| distances[i] != 0 && continue | ||
| distances[fwd] = collect(0:inc:inc*(length(fwd)-1)) | ||
| distances[rev] = collect(inc:inc:inc*(length(rev))) |
There was a problem hiding this comment.
This seems like a very inefficient way to do this? Maybe build a mapping from unique edges to vectors of their indices in edgelist as part of the MultiGraph?
There was a problem hiding this comment.
Wrote a more efficient new way (that also correctly does the curves for multiple fwd/rev edges). One pass through the array and then one pass through the dict. Think it should be the same as storing the dict, since we construct a new MultiGraphWrap everytime we call plot_network and plot_complexes anyway
isaacsas
requested changes
Nov 27, 2024
Co-authored-by: Sam Isaacson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1135. Should also resolve the documentation build issue in #1130.