-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphMakie docs update #1130
base: master
Are you sure you want to change the base?
GraphMakie docs update #1130
Conversation
You need to also update all the places in the current docs where we show graphs to use the new code (preferably dynamically). |
GLMakie tests are failing? |
seems something GLFW-related, happening in the docs build too. Will probably debug tomorrow |
ok |
Seems like somehow the |
seems like it was because GLMakie is loaded in that |
You seem to be getting hit by the same NonlinearSolve related doc build error I was seeing. This seems to have just appeared in the last day or so. |
Are you referring to the Cassette one? Has anyone upstreamed an issue to Cassette yet? |
@vyudu maybe just comment out that tutorial for now so we can get this merged? @ChrisRackauckas I don't know if anyone has upstreamed it -- I'm not sure anyone has investigated what is going on beyond seeing the doc build stack trace. |
I think this needs to merge after #1138 since I fix the other doc build error in that PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyudu I'll merge after you address my comments and I confirm the docs look ok with this. Thanks!
@@ -37,7 +37,7 @@ etc). | |||
- [JumpProcesses.jl](https://github.com/SciML/JumpProcesses.jl) can be used to numerically sample generated Stochastic Chemical Kinetics Jump Process models. | |||
- Support for [parallelization of all simulations](@ref ode_simulation_performance_parallelisation), including parallelization of [ODE simulations on GPUs](@ref ode_simulation_performance_parallelisation_GPU) using [DiffEqGPU.jl](https://github.com/SciML/DiffEqGPU.jl). | |||
- [Latexify](https://korsbo.github.io/Latexify.jl/stable/) can be used to [generate LaTeX expressions](@ref visualisation_latex) corresponding to generated mathematical models or the underlying set of reactions. | |||
- [Graphviz](https://graphviz.org/) can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs) (reusing the Graphviz interface created in [Catlab.jl](https://algebraicjulia.github.io/Catlab.jl/stable/)). | |||
- The GraphMakie package has [Makie](https://docs.makie.org/stable/) recipes that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The GraphMakie package has [Makie](https://docs.makie.org/stable/) recipes that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs) | |
- [GraphMakie](https://docs.makie.org/stable/) recipes are provided that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs) |
@@ -97,6 +91,7 @@ end | |||
|
|||
# Test spatial plotting, using CarioMakie and GraphMakie | |||
@time @safetestset "Lattice Simulation Plotting" begin include("extensions/lattice_simulation_plotting.jl") end | |||
@time @safetestset "Graph visualization" begin include("extensions/graphmakie.jl") end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this already in the extensions test section? (Which is more appropriate for it.)
Update docs and drop Graphviz dependency. Ran into an issue on my machine where
ExpandTemplates
was hanging for a really long time, so I changed some of the@example
blocks to just ```julia, but it was still sort of hanging on the machine so not sure what's happening. In any case wanted to see how it did on the CI.