Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphMakie docs update #1130

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

GraphMakie docs update #1130

wants to merge 31 commits into from

Conversation

vyudu
Copy link
Collaborator

@vyudu vyudu commented Nov 21, 2024

Update docs and drop Graphviz dependency. Ran into an issue on my machine where ExpandTemplates was hanging for a really long time, so I changed some of the @example blocks to just ```julia, but it was still sort of hanging on the machine so not sure what's happening. In any case wanted to see how it did on the CI.

@isaacsas
Copy link
Member

isaacsas commented Nov 21, 2024

You need to also update all the places in the current docs where we show graphs to use the new code (preferably dynamically).

@isaacsas
Copy link
Member

GLMakie tests are failing?

@vyudu
Copy link
Collaborator Author

vyudu commented Nov 21, 2024

seems something GLFW-related, happening in the docs build too. Will probably debug tomorrow

@isaacsas
Copy link
Member

ok

@isaacsas
Copy link
Member

Seems like somehow the plot from Makie is getting loaded now even in tutorials that don't use Makie for plotting?

@vyudu
Copy link
Collaborator Author

vyudu commented Nov 23, 2024

seems like it was because GLMakie is loaded in that @example block, added an explicit import to fix

@vyudu vyudu mentioned this pull request Nov 25, 2024
@isaacsas
Copy link
Member

You seem to be getting hit by the same NonlinearSolve related doc build error I was seeing. This seems to have just appeared in the last day or so.

@ChrisRackauckas
Copy link
Member

Are you referring to the Cassette one? Has anyone upstreamed an issue to Cassette yet?

@isaacsas
Copy link
Member

@vyudu maybe just comment out that tutorial for now so we can get this merged?

@ChrisRackauckas I don't know if anyone has upstreamed it -- I'm not sure anyone has investigated what is going on beyond seeing the doc build stack trace.

@vyudu
Copy link
Collaborator Author

vyudu commented Nov 26, 2024

I think this needs to merge after #1138 since I fix the other doc build error in that PR

Copy link
Member

@isaacsas isaacsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyudu I'll merge after you address my comments and I confirm the docs look ok with this. Thanks!

@@ -37,7 +37,7 @@ etc).
- [JumpProcesses.jl](https://github.com/SciML/JumpProcesses.jl) can be used to numerically sample generated Stochastic Chemical Kinetics Jump Process models.
- Support for [parallelization of all simulations](@ref ode_simulation_performance_parallelisation), including parallelization of [ODE simulations on GPUs](@ref ode_simulation_performance_parallelisation_GPU) using [DiffEqGPU.jl](https://github.com/SciML/DiffEqGPU.jl).
- [Latexify](https://korsbo.github.io/Latexify.jl/stable/) can be used to [generate LaTeX expressions](@ref visualisation_latex) corresponding to generated mathematical models or the underlying set of reactions.
- [Graphviz](https://graphviz.org/) can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs) (reusing the Graphviz interface created in [Catlab.jl](https://algebraicjulia.github.io/Catlab.jl/stable/)).
- The GraphMakie package has [Makie](https://docs.makie.org/stable/) recipes that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The GraphMakie package has [Makie](https://docs.makie.org/stable/) recipes that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs)
- [GraphMakie](https://docs.makie.org/stable/) recipes are provided that can be used to generate and [visualize reaction network graphs](@ref visualisation_graphs)

@@ -97,6 +91,7 @@ end

# Test spatial plotting, using CarioMakie and GraphMakie
@time @safetestset "Lattice Simulation Plotting" begin include("extensions/lattice_simulation_plotting.jl") end
@time @safetestset "Graph visualization" begin include("extensions/graphmakie.jl") end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already in the extensions test section? (Which is more appropriate for it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants