-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@require_declaration
docs
#1129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
requested changes
Nov 20, 2024
Comment on lines
278
to
284
```@example dsl_advanced_no_infer | ||
using Catalyst | ||
# The following case will throw an UndeclaredSymbolicError. | ||
rn = @reaction_network begin | ||
@require_declaration | ||
(k1, k2), A <--> B | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep Documenter.jl from failing the build you probably need to catch the error here. (Otherwise just don't make this dynamic and manually paste in the output.)
Co-authored-by: Sam Isaacson <[email protected]>
isaacsas
reviewed
Nov 20, 2024
TorkelE
reviewed
Nov 20, 2024
TorkelE
reviewed
Nov 20, 2024
TorkelE
reviewed
Nov 20, 2024
This is already merged but feel free to follow up and tweak. |
TorkelE
reviewed
Nov 20, 2024
TorkelE
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some starting docs for it. Might be a better spot than where I put it (end of the "Explicit specification of network species and parameters" heading)