Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save datasets to files #30

Open
jl-wynen opened this issue Jan 3, 2023 · 3 comments
Open

Save datasets to files #30

jl-wynen opened this issue Jan 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jl-wynen
Copy link
Collaborator

jl-wynen commented Jan 3, 2023

Should be enough to serialize the models to JSON.

@jl-wynen jl-wynen added the enhancement New feature or request label Jan 3, 2023
@nitrosx
Copy link
Collaborator

nitrosx commented Jan 4, 2023

Could you please elaborate more on this functionality?

@jl-wynen
Copy link
Collaborator Author

jl-wynen commented Jan 4, 2023

Early on, we discussed that it can be useful to download datasets ahead of time and use them later on, e.g. on a plane w/o internet connection.

So my suggestion would be to add methods to Dataset to save to / load from JSON. This would mostly require serializing the models. Except File, where we need to be more careful because of File.local_path.

@nitrosx
Copy link
Collaborator

nitrosx commented Jan 4, 2023

Now I remember. Let me know if we need to brainstorm again

@nvaytet nvaytet self-assigned this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants