Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add WSL as a make target, to apply fixes automatically #377

Open
2 tasks done
zalgonoise opened this issue Apr 11, 2024 · 2 comments
Open
2 tasks done

[feature] Add WSL as a make target, to apply fixes automatically #377

zalgonoise opened this issue Apr 11, 2024 · 2 comments
Labels
proposal Feature request proposal-accepted A proposal that has been accepted

Comments

@zalgonoise
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Our linter configuration is not performing any automatic actions that could improve the quality of life of the SWE

Describe the solution you'd like

Adding wsl as a make target so that we can auto-fix WSL-related warnings, reducing to a great extent the linter warning messages.

Describe alternatives you've considered

we can install and execute wsl in a make target: https://github.com/bombsimon/wsl?tab=readme-ov-file#usage

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@zalgonoise zalgonoise added the proposal Feature request label Apr 11, 2024
@MarvinJWendt
Copy link
Member

How about running the make target in a pre-commit hook too?

@zalgonoise
Copy link
Contributor Author

Since it applies changes to the code with the --fix flag, I thought the caller should execute the make target beforehand (even if just adding newlines) :D

It should be OK to add it to git pre-commit hooks, but how would one deal with the changes? Should the script also commit the files? Or exit with status code 1 and let the caller deal with the commits?

@MarvinJWendt MarvinJWendt added the proposal-accepted A proposal that has been accepted label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Feature request proposal-accepted A proposal that has been accepted
Projects
None yet
Development

No branches or pull requests

2 participants