DOA Checks really necessary?

[fabiolamicela]

Hi,

I wanted to ask if the DOA check for PRs is really neccessary for this project?

I've create this PR #61 via the github website and the update to the file was apperantly automatically "signed-off-by" myself without any further effort. But as you can see the merge did not include the "signed-off-by" message. I`m not sure if this caused the DOA check to fail or anything else - but it was pretty annoying to fix this via a local code checkout, revert and force push for a simple readme adjustment. The "hurdle" to quickly improve this project is imho very high so I would like to discuss if the checks are really necessary because of legal requirements or could they be deactiveated?

Git Log:

Author: fabiolamicela <[email protected]>
Date:   Thu Nov 18 08:43:04 2021 +0100

    Merge branch 'patch-1' of https://github.com/fabiolamicela/go-template into pr/61

commit 0dc982e1ecdef36b42ce606d96a52cf9021e8045
Author: fabiolamicela <[email protected]>
Date:   Thu Nov 18 08:26:33 2021 +0100

    Update README.md

    Co-authored-by: Tobias Brumhard <[email protected]>
    Signed-off-by: fabiolamicela <[email protected]>

commit 7416d5a109c4e463ac5bd1627d155ccb520e7144
Author: fabiolamicela <[email protected]>
Date:   Thu Nov 11 10:54:14 2021 +0100

    Update README.md

    Simply running `gt new` as described in the readme does not work since the binary is installed in the GOBIN path

    Signed-off-by: fabiolamicela <[email protected]>

commit 2f85f614ec291bc46af0105523c275fb1ba63d56
Author: fabiolamicela <[email protected]>
Date:   Thu Nov 18 08:26:33 2021 +0100

    Update README.md

    Co-authored-by: Tobias Brumhard <[email protected]>

commit 35f96fbcb10148c166a3fb6ad99ff3eab27e223f
Author: fabiolamicela <[email protected]>
Date:   Thu Nov 11 10:54:14 2021 +0100

    Update README.md

    Simply running `gt new` as described in the readme does not work since the binary is installed in the GOBIN path

commit f207f51bd66da5479073412685f05fb4e8cdabd8 (origin/main, origin/HEAD, main)
Author: Steffen Exler <[email protected]>
Date:   Tue Nov 2 08:54:46 2021 +0100

    docs: add go report card badge (#56)

    Signed-off-by: Steffen Exler <[email protected]>```

[brumhard]

Agreed to remove the DOA check. Thx for the hint for improvement :)

[patrick246]

It's removed

[fabiolamicela]

Awesome, thank you