Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta issue: Various improvements #87

Closed
timmc opened this issue Jul 27, 2020 · 5 comments
Closed

Meta issue: Various improvements #87

timmc opened this issue Jul 27, 2020 · 5 comments

Comments

@timmc
Copy link

timmc commented Jul 27, 2020

I started a fork of this repo to do my own export of Wordpress to Hugo, and ended up accumulating a number of changes:

master...timmc:hugo-last

Some of these are purely for my own interests, while others are general improvements or bugfixes. If you're interested, you might want to mine those commits for useful changes. (Note that there are a couple of more recent commits that aren't relevant; I ended up targeting a custom static site generator rather than Hugo.)

If this ticket is not of interest, feel free to close it! But here are changes that might be useful to implement or create TODOs for:

  • Bugfix: Put posts in content/post/ instead of posts/ to match Hugo's expectations
  • Posts are index.md files in individual directories under content/, and each comment is a separate Markdown file in that dir
  • Merge categories into tags
  • Exclude default category (I hardcoded the name)
  • Add id to post metadata
  • Include pingbacks/trackbacks along with other comments
  • Bugfix: Detect posts with all-zeroes dates, including where GMT date is invalid but non-GMT date is usable, and treat them as undated
  • Bugfix: Change exporter to send zip file to stdout like CLI wrapper claims it will
  • Include instructions in CLI wrapper for multi-host setups
  • Bugfix: Fix hugo config.yaml creation (correct keys, and simpler process)
  • Put everything in root of zip file, not under another folder
  • Don't put trailing slashes on directory path strings; add trailing slash when concatenating instead (shouldn't change behavior, but makes path manipulation more predictable)
  • Special-case openid_comments postmeta by applying to comments directly
    • Only relevant for people who used that Wordpress plugin
@SchumacherFM
Copy link
Owner

Dear Tim, thank you very much! That sounds awesome! If you wish, I can add you as a contributor so you can push changes without a pull request. Let me know if you are interested. Otherwise I will merge your changes during the next months.

@SchumacherFM SchumacherFM pinned this issue Jul 28, 2020
@timmc
Copy link
Author

timmc commented Jul 28, 2020

Glad to hear it might be useful, but I don't think I have time left for that -- and I ended up not using Hugo after all, but something I wrote, so I wouldn't be able to test it on my own site. (I spent too long trying to wrangle Hugo templates, and realized I could write a static site generator from scratch more quickly than the template I wanted! I'll try to open source that later.)

Hopefully these can serve as a springboard for you or someone else to pick out any generally useful improvements.

(Probably the most valuable ones are the ones called out as bugfixes here, but in the actual commits they're sometimes mixed in with other changes. The commit messages should be accurate enough to find them, though!)

@SchumacherFM
Copy link
Owner

@timmc a year later ... any updates on this?

I'm a bit reluctant to close this issue as it provides some good points to work on for someone.

@timmc
Copy link
Author

timmc commented Aug 10, 2021

I'm no longer using Wordpress and don't have further plans to use Hugo (or this exporter), so I won't be doing any work on it.

Feel free to close, leave open, or break out into issues as you see fit -- whatever you think is best. You could even just close it and link to it from/copy into a "possible improvements" doc if you wanted to keep a record of any interesting features or bugs.

@SchumacherFM
Copy link
Owner

closing this due to age. please reopen if the problem still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants