Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy image to dockerhub #125

Open
Wabri opened this issue Sep 20, 2024 · 3 comments
Open

Deploy image to dockerhub #125

Wabri opened this issue Sep 20, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Wabri
Copy link
Member

Wabri commented Sep 20, 2024

Issues or necessity of a feature
We have a docker hub user https://hub.docker.com/u/schroedingerhat now we can setup the pipeline to deploy the image.

Step to reproduce the bug / needs of a new feature
https://docs.docker.com/docker-hub/quickstart/

@Wabri Wabri added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2024
@TheJoin95
Copy link
Member

I can take it

@TheJoin95
Copy link
Member

https://hub.docker.com/r/schroedingerhat/y2s

I feel that won't work as we're not getting any custom input so the file where we have the youtube video ID is not changing.
@matevskial maybe we should have something in input or change the way we see things for the docker

@matevskial
Copy link
Contributor

@TheJoin95 In a previous PR I made y2s to accept episode id through environment variable too, so it is possible to specify an episode id. Next we should update the documentation on how to use the standalone docker image amd then we can do an official release :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants