Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision should be 1 when TP=1 and FP=0 #338

Open
kelly-sovacool opened this issue Jun 6, 2023 · 0 comments
Open

Precision should be 1 when TP=1 and FP=0 #338

kelly-sovacool opened this issue Jun 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@kelly-sovacool
Copy link
Member

caret uses MLmetrics::PRAUC(), which reports precision as NA when TP=1 and FP=0. As a result, the prAUC value reported by caret is overinflated because it drops NA values.

Solution: use yardstick::pr_auc(), which uses the convention that precision is 1 when TP=1 and FP=0.

See tidymodels/yardstick#166 & tidymodels/yardstick#95
@kelly-sovacool kelly-sovacool added the bug Something isn't working label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kelly-sovacool