-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hyperparameter tuning plot functionality (and maybe other plots) #122
Comments
@kelly-sovacool and I discussed having plots in the package that plot the output of multiple ML runs. Current ideas:
|
I have some ggplot code to make nice dotplots with mean/median stats for AUPROC and AUROC values that we can implement if we want. |
@BTopcuoglu do you want to get started on making a dotplot function based on your code then? |
Now that I thought about this a little - this might be a better venue for snakemake workflow. Because the tuning results would not mean much if they are done only for 1 seed. The best hp you get in 1 datasplit might not be the same in another. Similarly the AUROC plots would make sense for 100 datasplit averages/medians but not for 1 datasplit. |
Any plots which are better for multiple seeds should take a dataframe with each row as the result from one seed. We should probably include a function to merge results like the merge_results rule in https://github.com/SchlossLab/mikRopML-snakemake-workflow. |
@BTopcuoglu have you pushed the progress you've made? |
I do have some code for hyperparameter tuning too..but it looks pretty bad right now :) https://github.com/SchlossLab/Topcuoglu_ML_mBio_2020/blob/master/code/learning/FigureS2.R |
Does anyone have example code for feature importance plots? Would be nice to show an example in the Snakemake workflow, regardless of whether we include it in the package. |
|
@BTopcuoglu: @pschloss was asking about when we might have plots for hyperparameter tuning incorporated. Would be helpful for @courtneyarmour's project. I know we'll also need to document tuning better (#201). |
Made a draft in branch iss-122_hp-plot. @BTopcuoglu feel free to modify if you'd like! |
Working on it now. |
Like @zenalapp suggested, it would be a good idea to export a figure that shows the user whether they are exhausting the tuning for hyperparameters (e.g. using all the cost parameters until we see a global maxima for ROC).
The text was updated successfully, but these errors were encountered: