-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle multiple http servers with one graceful service #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment:
Do we really have to define the number of servers in the constructor as option. Can't it be counted when s.ListenAndServe
is called?
We need to know "when" to call the tableflip upgrader "Ready()" method. I saw three options:
I chose option 2 because:
I am happy to change it if you have any better ideas / preferences. In the meantime, there is a "race" in this PR, so I am going to fix that, and send an update shortly. |
Really good explanation, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validating the chosen methodology, letting Pierre for the code analysis :)
Related to Scalingo/go-utils#944
Related to Scalingo/go-utils#944 Finalise merge of master
Related to Scalingo/go-utils#944 Lint
Related to Scalingo/go-utils#944 Lint
@curzolapierre this is ready for code review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments about style of logs and errors.
Otherwise LGTM
4cf237a
to
0784107
Compare
@EtienneM Before I merge this, I would appreciate a discussion about it if you have time. Thanks in advance |
Related to Scalingo/go-utils#944 With etienne's expert eye
Related to Scalingo/go-utils#944 Fix TLS config initialisation
Fixes #271 Related to Scalingo/go-utils#944
Prerequisite to fix sand issue: Scalingo/sand#271 (since graceful v1.1.2)
Related to PR #909
Related to Story STORY-828
CHANGELOG.md