Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environments #26

Open
iloveicedgreentea opened this issue Jul 16, 2020 · 3 comments
Open

Add environments #26

iloveicedgreentea opened this issue Jul 16, 2020 · 3 comments
Assignees
@iloveicedgreentea
Labels
enhancement New feature or request

Comments

@iloveicedgreentea
Copy link
Contributor

Need to add dev/prod

Dev can have a shadow twitter account as well
@iloveicedgreentea iloveicedgreentea added the enhancement New feature or request label Jul 16, 2020
@iloveicedgreentea iloveicedgreentea self-assigned this Jul 16, 2020
@jdyke
Copy link
Collaborator

jdyke commented Jul 18, 2020

+1 separate state files

@iloveicedgreentea
Copy link
Contributor Author

#25 started in here but once that is merged I will make a separate branch for it

@iloveicedgreentea
Copy link
Contributor Author

@jdyke @aaronrea I added support for multiple envs and separate state files. I did it in #25 because it was all commingled.

Please check the TF plan here https://github.com/ScaleSec/gcp_org_policy_notifier/runs/985301837?check_suite_focus=true

It would create new resources for dev and prod. I already migrated the prod state file so it would destroy and recreate everything appropriately (nothing touched in prod now though)

Once this is accepted we will just have to modify the TF apply logic and then we can start testing in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveicedgreentea iloveicedgreentea

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdyke @iloveicedgreentea