Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert number IDs to BigInt #976

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: convert number IDs to BigInt #976

wants to merge 1 commit into from

Conversation

moltar
Copy link
Contributor

@moltar moltar commented Aug 5, 2022

Convert all number identifiers to BigInt.

Closes: #975

@NishealJ
Copy link
Contributor

NishealJ commented Aug 7, 2022

@moltar we'll have to cover all the ids right? keywordId, adgroupId etc.
Also while sending a request to amazon we can send them as a string (but not sure if all the APIs accept them as String).

@moltar
Copy link
Contributor Author

moltar commented Aug 7, 2022

Ya that's the hardest part is to feed them ints back. Not sure if the api will accept strings. Need to experiment. However, it should be still possible to use some custom serialization method to convert stringified ints to proper ints. Even if it means just using a regex to strip off " from string json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Apis sends campaignId as number/integer
2 participants