Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-48: fix ktlint version retrieval #50

Closed
wants to merge 4 commits into from
Closed

GH-48: fix ktlint version retrieval #50

wants to merge 4 commits into from

Conversation

ghaiszaher
Copy link
Member

@ghaiszaher ghaiszaher commented Feb 29, 2024 •
edited
Loading

Fixes #48

@ghaiszaher ghaiszaher marked this pull request as ready for review February 29, 2024 08:17
@ghaiszaher ghaiszaher requested a review from a team as a code owner February 29, 2024 08:17
@ghaiszaher ghaiszaher mentioned this pull request Feb 29, 2024
Closed
@ghaiszaher ghaiszaher changed the title GH-48: deprecated code-style GH-48: fix ktlint version retrieval Feb 29, 2024
guil-camp-scacap
guil-camp-scacap approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@guil-camp-scacap guil-camp-scacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

TIL: ${ktlint_version#"ktlint version "} to remove a prefix 🎉

@unaisquyyum-scalable
Copy link

@ScaCap/action-ktlint-maintainers can you please approve this PR?

@ghaiszaher ghaiszaher closed this Feb 29, 2024
@guil-camp-scacap guil-camp-scacap mentioned this pull request Feb 29, 2024
Merged
@ghaiszaher
Copy link
Member Author

Replaced by #51

@guil-camp-scacap guil-camp-scacap deleted the GH-48/fix branch February 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guil-camp-scacap guil-camp-scacap guil-camp-scacap approved these changes

@johnk-scalable johnk-scalable johnk-scalable approved these changes

@unaisquyyum-scalable unaisquyyum-scalable unaisquyyum-scalable approved these changes

@dmichel90 dmichel90 dmichel90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--code-style argument will cause error
5 participants
@ghaiszaher @unaisquyyum-scalable @dmichel90 @johnk-scalable @guil-camp-scacap