From 3a4b0cbaaecf55289ed65b1b60c64e6030fb1ab8 Mon Sep 17 00:00:00 2001
From: freya <frybrdrck@gmail.com>
Date: Wed, 10 Jan 2024 00:01:37 +0000
Subject: [PATCH] Fix Per Item Loot Manager (#66)

* ignore null case and return 0 for characters that haven't received items

* bump version and update changelog
---
 backend/backend/settings_live.py               |  2 +-
 frontend/.env                                  |  2 +-
 .../src/components/loot_manager/per_item.vue   |  4 ++--
 frontend/src/components/modals/changelog.vue   | 18 ++----------------
 frontend/src/main.ts                           |  2 +-
 5 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/backend/backend/settings_live.py b/backend/backend/settings_live.py
index 1dee9569..d1d0d332 100644
--- a/backend/backend/settings_live.py
+++ b/backend/backend/settings_live.py
@@ -184,7 +184,7 @@ def sampler(context):
     # If you wish to associate users to errors (assuming you are using
     # django.contrib.auth) you may enable sending PII data.
     send_default_pii=True,
-    release='savageaim@20231227',
+    release='savageaim@20240109',
 )
 
 # Channels
diff --git a/frontend/.env b/frontend/.env
index 5a645f10..16365277 100644
--- a/frontend/.env
+++ b/frontend/.env
@@ -1 +1 @@
-VUE_APP_VERSION="20231227"
+VUE_APP_VERSION="20240109"
diff --git a/frontend/src/components/loot_manager/per_item.vue b/frontend/src/components/loot_manager/per_item.vue
index 16da70c8..91c697d9 100644
--- a/frontend/src/components/loot_manager/per_item.vue
+++ b/frontend/src/components/loot_manager/per_item.vue
@@ -132,12 +132,12 @@ export default class PerItemLootManager extends Vue {
 
   getGreedReceived(entry: GreedGear): number {
     // Given an entry, return how many times that Character has received greed loot so far this tier
-    return this.loot.received[entry.character_name].greed
+    return this.loot.received[entry.character_name]?.greed || 0
   }
 
   getNeedReceived(entry: NeedGear): number {
     // Given an entry, return how many times that Character has received need loot so far this tier
-    return this.loot.received[entry.character_name].need
+    return this.loot.received[entry.character_name]?.need || 0
   }
 
   // Functions to handle interacting with the API for handling loot handouts
diff --git a/frontend/src/components/modals/changelog.vue b/frontend/src/components/modals/changelog.vue
index 565745ca..ee907795 100644
--- a/frontend/src/components/modals/changelog.vue
+++ b/frontend/src/components/modals/changelog.vue
@@ -12,22 +12,8 @@
     </div>
     <div class="card-content content">
       <h2 class="has-text-primary subtitle">{{ version }}</h2>
-      <div class="divider"><i class="material-icons icon">auto_awesome</i> Happy Holidays and Happy New Year <i class="material-icons icon">auto_awesome</i></div>
-      <p>Hard to believe I've been at this for nearly 2 years now! Hope everyone had a good end to 2023 and a nice start to 2024. Roll on Dawntrail!!</p>
-
-      <div class="divider"><i class="material-icons icon">expand_more</i> Navigation Changes <i class="material-icons icon">expand_more</i></div>
-      <p>The explanation for what colours mean has been moved to the Theme settings page, and removed from the navbar.</p>
-      <p>
-        A quick-switcher (similar to Discord's) has been added for faster moving between pages.
-        <ul>
-          <li>It's accessible through the navbar, or by pressing <code>Ctrl</code>+<code>K</code> on PC.</li>
-          <li>This menu allows you to type to search for pages, and select them via arrow keys or clicking/tapping.</li>
-          <li>It shows the top 5 most relevant items to your search, and when empty the list displays main character / team pages instead.</li>
-        </ul>
-      </p>
-
-      <div class="divider"><i class="material-icons icon">expand_more</i> Other Fixes <i class="material-icons icon">expand_more</i></div>
-      <p>If a non-leader accesses the Team's Settings page, the redirect will now put them back on the correct page.</p>
+      <div class="divider"><i class="material-icons icon">expand_more</i> Fixes <i class="material-icons icon">expand_more</i></div>
+      <p>Fixed an issue in the Per-Item Loot Manager where having Team Members who haven't received loot would cause the dropdown to not work. (Thanks @natkr!)</p>
 
     </div>
   </div>
diff --git a/frontend/src/main.ts b/frontend/src/main.ts
index 01caa056..f79421b6 100644
--- a/frontend/src/main.ts
+++ b/frontend/src/main.ts
@@ -30,7 +30,7 @@ Sentry.init({
   Vue,
   dsn: 'https://06f41b525a40497a848fb726f6d03244@o242258.ingest.sentry.io/6180221',
   logErrors: true,
-  release: 'savageaim@20231227',
+  release: 'savageaim@20240109',
   integrations: [
     new Sentry.BrowserTracing({
       routingInstrumentation: Sentry.vueRouterInstrumentation(router),