Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 Item Components not being saved to yaml value. #58

Open
GentlemanCheesy opened this issue Jul 30, 2024 · 8 comments
Open

1.21 Item Components not being saved to yaml value. #58

GentlemanCheesy opened this issue Jul 30, 2024 · 8 comments

Comments

@GentlemanCheesy
Copy link

For some reason items I'm saving to a yaml file are not keeping their "Tool Rules" components they have when saved. It defaults back to the default tool rules of a wooden pickaxe as that's the item that has the custom tool rules.
image

Tested on Paper 1.21 with Skript 2.9.0 and Skript-Yaml 1.5
Before:
image
After:
image

@EternalHellTTV
Copy link

Yaml has not been updated for over a year, There would be issues as 1.21 did major changes. 1.20.4 does work fine

@Sashie
Copy link
Owner

Sashie commented Oct 26, 2024

By chance was the data already saved from a previous minecraft version and then after loading it and saving it in 1.21 it lost that certain data?

@GentlemanCheesy
Copy link
Author

GentlemanCheesy commented Oct 26, 2024

I'm almost certain that this data was saved and loaded on the same version, 1.21

@Sashie
Copy link
Owner

Sashie commented Oct 26, 2024

So it saves it fine but after load its missing data?

@GentlemanCheesy
Copy link
Author

I have attempted this again and found that there is an error in console upon saving the item. You can find that error from my logs at this pastebin link: https://pastebin.com/P7F2VexB

The same result with the saved item losing its tool data during the save. Giving myself the saved item has default tool data of whatever pickaxe is used.

@GentlemanCheesy
Copy link
Author

It seems that not including a speed for a tool rule has some sort of effect on the save (if i am reading the error correctly). Which is strange since by default pickaxes dont include a speed with the tag for incorrect blocks for that tool type.
image

@Sashie
Copy link
Owner

Sashie commented Oct 26, 2024

When I get home I'll check that error and see about fixing it for the next version, if you have discord and are in the skunity group message me and I can let you test the new version

Could you please provide the skript code to produce this error as well?

@GentlemanCheesy
Copy link
Author

GentlemanCheesy commented Oct 27, 2024

Here is the script i am using, if you dont already have an item that can be saved for testing use: https://mcstacker.net
I can provide a pre-saved item.yml if need be.

itemsavecopy.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants