Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0: Rerunning an OpenCL fit with DREAM throws errors #3126

Closed
krzywon opened this issue Oct 16, 2024 · 1 comment
Closed

6.0.0: Rerunning an OpenCL fit with DREAM throws errors #3126

krzywon opened this issue Oct 16, 2024 · 1 comment

Comments

@krzywon
Copy link
Contributor

krzywon commented Oct 16, 2024

Describe the bug
A video showing how to reproduce the error.

To Reproduce
Steps to reproduce the behavior:

  1. Run any fit with OpenCL enabled, and any optimizer other than DREAM.
  2. Once the fit is complete, switch to the DREAM fitter and run the fit again.
  3. Errors thrown and the fit tab will no longer run any fits with that particular model.

Expected behavior
The fit should run.

SasView version (please complete the following information):

  • Version: v6.0.0

Operating system (please complete the following information):

  • OS: Win10, MacOS (arm and x86)
@krzywon
Copy link
Contributor Author

krzywon commented Oct 17, 2024

A few hours with @pkienzle and we have found the 2 underlying issues. The one seen by @wpotrzebowski in the posted video is due to a single fit parameter selected which causes a change in the covariance calculation. I have that fixed locally. The 2nd, OpenCL error, is because the OpenCL environment was being reset when any preference was being changed. I am working on a reliable fix for this one, but am nearly there. Expect a PR this afternoon (EST).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant