You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug setup.py install should install sasview and have it work; running tests assumes that it does work and so this is called from CI.
However, setup.py doesn't know about any of the non-python files ("package-data" in setuptools parlance) that sasview requires. There's are hundreds of images, icons, stylesheets etc that are required at runtime.
This is papered over in installers/sasview.spec with a curated list of data files to include. Pushing this into the sasview package itself so that they land in the wheel will help clean up numerous pain points... including making sasview installable via pip.
To Reproduce
Steps to reproduce the behavior:
create venv, enter it, install deps as normal
git clone ...
pip install .
sasview
See error
Expected behavior
sasview installation in the venv is a working installation
Errors FileNotFoundError for sas/qtgui/images/SVwelcome.png that results in sasview crashing immediately. (And if you fix that one, there are many more)
SasView version (please complete the following information):
Version: git HEAD (main branch tested)
Operating system (please complete the following information):
OS: Linux (but that's not relevant)
Additional context
Copying the files in manually lets sasview start - we're not a million miles from this working. The config really just needs to get into pyproject.toml (or at worst setup.py) and then wheels become a simple reality.
Crudely (and copying more that strictly necessary in order to get it working...):
$ find sasview/src/sas/qtgui/ -type d | cut -d/ -f3- | while read d; do mkdir -p venv/lib/python3.11/site-packages/$d ; done
$ find sasview/src/sas/qtgui/ -type f \! -name \*py | cut -f3- -d/ | while read f; do cp "sasview/src/$f" venv/lib/python3.11/site-packages/$f; done
The text was updated successfully, but these errors were encountered:
Describe the bug
setup.py install
should install sasview and have it work; running tests assumes that it does work and so this is called from CI.However,
setup.py
doesn't know about any of the non-python files ("package-data" in setuptools parlance) that sasview requires. There's are hundreds of images, icons, stylesheets etc that are required at runtime.This is papered over in
installers/sasview.spec
with a curated list of data files to include. Pushing this into the sasview package itself so that they land in the wheel will help clean up numerous pain points... including making sasview installable viapip
.To Reproduce
Steps to reproduce the behavior:
git clone ...
pip install .
sasview
Expected behavior
sasview installation in the venv is a working installation
Errors
FileNotFoundError
forsas/qtgui/images/SVwelcome.png
that results in sasview crashing immediately. (And if you fix that one, there are many more)SasView version (please complete the following information):
Operating system (please complete the following information):
Additional context
Copying the files in manually lets sasview start - we're not a million miles from this working. The config really just needs to get into
pyproject.toml
(or at worstsetup.py
) and then wheels become a simple reality.Crudely (and copying more that strictly necessary in order to get it working...):
The text was updated successfully, but these errors were encountered: