Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin editor not show model errors on save #1595

Closed
pkienzle opened this issue Jun 16, 2020 · 1 comment
Closed

Plugin editor not show model errors on save #1595

pkienzle opened this issue Jun 16, 2020 · 1 comment
Labels
Defect Bug or undesirable behaviour
Milestone

Comments

@pkienzle
Copy link
Contributor

The plugin editor says the plugin was saved and then proceeds to ignore it, changing the plugin model selected in the fit page dropdown to one that has no errors.

There is no error listed in the console, though a warning is appearing in sasview.log:

11:49:08 - WARNING: Failed to load plugin '.../.sasview/plugin_models/longcylinder.py'. See .../.sasview/plugin_models/plugins.log for details

and the error is properly listed in plugin.log

@rozyczko rozyczko added the Defect Bug or undesirable behaviour label Jun 18, 2020
@rozyczko rozyczko added this to the SasView 5.0.4 milestone Jun 18, 2020
@butlerpd butlerpd changed the title ESS_GUI: plugin editor not show model errors on save plugin editor not show model errors on save May 2, 2021
@butlerpd butlerpd modified the milestones: SasView 5.0.4, SasView 5.0.5 May 2, 2021
@butlerpd butlerpd changed the title plugin editor not show model errors on save Plugin editor not show model errors on save May 2, 2021
@butlerpd butlerpd modified the milestones: SasView 5.0.5, SasView 5.1.0 Feb 1, 2022
@tsole0 tsole0 mentioned this issue Jun 21, 2024
7 tasks
@tsole0
Copy link
Contributor

tsole0 commented Jun 28, 2024

Closed as unreproducible.

Discussed with @pkienzle and does not seem reproducible in current SasView version or is already fixed by #2901. Investigated loading broken models on launch, after editing model, before editing model, after fixing and re-breaking. Described behavior (changing the plugin model selected in the fit page dropdown to one that has no errors) is not observed. Also investigated model caching when saving models and its interaction with the fitting window/model editor, but observed nothing unusual. It seems that the current version of SasView will use the .so compiled C model that was used when the model was loaded into the fitting window if the C model is broken while loaded into the fitting window, which is an acceptable behavior.

@tsole0 tsole0 closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

4 participants