Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map.stippling does not work with station data #24

Open
rmanzanas opened this issue Jul 8, 2019 · 2 comments
Open

map.stippling does not work with station data #24

rmanzanas opened this issue Jul 8, 2019 · 2 comments

Comments

@rmanzanas
Copy link
Member

The map.stippling function gives an error when applied on station data (it works well for gridded data). This would be an example:

pval = climatology(VALUE_Iberia_tas, clim.fun = list(FUN = "trend.1D", dates = getRefDates(VALUE_Iberia_tas), method = "kendall", return.pvalue = T))

sig = map.stippling(clim = pval, threshold = 0.05, condition = "LT", pch = 19, cex = .1, col = "black") # points exhibiting significant trends

@rmanzanas rmanzanas added the bug label Jul 8, 2019
@jbedia jbedia added enhancement and removed bug labels Jul 9, 2019
@jbedia
Copy link
Member

jbedia commented Jul 9, 2019

Hi, the stippling is not in principle intended to work with point data. You can use the index of significant/non-significant stations to highlight them at your convenience. Is it the best way to overlay one point layer on top of another? It can be easily implemented if this is what you want

@rmanzanas
Copy link
Member Author

Hi, @jbedia. Perhaps implementing the function in a way that allows working indistinctly with gridded and point-wise data would be ideal in terms of consistency (just a suggestion, this is nothing critical...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants