You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Sanja969 👋
In this issue I am going to review your code for JavaScript best practices.🙂
Reviewed DRY
I have considered your code for DRY( Don't Repeat Yourself ) and it was very clean and there was not extra repetition.🤩
Reviewed KISS
Dear Sanja I reviewed your code for KISS( Keep It Simple, Smart ) and there are some points that you can improve it and make it better.
in here if you remove === true your code will still work.
Reviewed Naming
You could use more clear names for your elements that if someone else consider your code, it increase the code readability. for example:
instead of 'toDoListUI' you could use 'listsContainer' because it is more clear that it is a container of lists
instead of 'endCont' you could use 'deleteCheckedBtn'
Hi @Sanja969 👋
In this issue I am going to review your code for JavaScript best practices.🙂
Reviewed DRY
I have considered your code for DRY( Don't Repeat Yourself ) and it was very clean and there was not extra repetition.🤩
Reviewed KISS
Dear Sanja I reviewed your code for KISS( Keep It Simple, Smart ) and there are some points that you can improve it and make it better.
in here if you remove
=== true
your code will still work.Reviewed Naming
You could use more clear names for your elements that if someone else consider your code, it increase the code readability. for example:
instead of 'toDoListUI' you could use 'listsContainer' because it is more clear that it is a container of lists
instead of 'endCont' you could use 'deleteCheckedBtn'
instead of 'moveImg' you could use editImg,
instead of 'check' you could use 'checkBox'
Type Checks
You have used very strong checks.🤑
GOOD LUCK @Sanja969 🏆
The text was updated successfully, but these errors were encountered: