Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does my coding partner follow JS best practices? #15

Open
4 tasks done
Sahar-SE opened this issue Jan 5, 2023 · 0 comments
Open
4 tasks done

Does my coding partner follow JS best practices? #15

Sahar-SE opened this issue Jan 5, 2023 · 0 comments

Comments

@Sahar-SE
Copy link
Collaborator

Sahar-SE commented Jan 5, 2023

Hi @Sanja969 👋
In this issue I am going to review your code for JavaScript best practices.🙂

  • Reviewed DRY
    I have considered your code for DRY( Don't Repeat Yourself ) and it was very clean and there was not extra repetition.🤩

  • Reviewed KISS
    Dear Sanja I reviewed your code for KISS( Keep It Simple, Smart ) and there are some points that you can improve it and make it better.
    image
    in here if you remove === true your code will still work.

  • Reviewed Naming
    You could use more clear names for your elements that if someone else consider your code, it increase the code readability. for example:

  • instead of 'toDoListUI' you could use 'listsContainer' because it is more clear that it is a container of lists

  • instead of 'endCont' you could use 'deleteCheckedBtn'

  • instead of 'moveImg' you could use editImg,

  • instead of 'check' you could use 'checkBox'

  • Type Checks
    You have used very strong checks.🤑

GOOD LUCK @Sanja969 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant