Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Text input field for email in newsletter #379

Closed
2 tasks done
PranavKeshav24 opened this issue Jun 13, 2024 · 5 comments · Fixed by #401
Closed
2 tasks done

Bug: Text input field for email in newsletter #379

PranavKeshav24 opened this issue Jun 13, 2024 · 5 comments · Fixed by #401
Assignees
Labels
BEGINNER Difficulty Level: Beginner 🪲 bug Something isn't working 🛠 goal: fix The label is related to fixing a bug gssoc GSSOC'24 Required Label

Comments

@PranavKeshav24
Copy link

What happened?

The text input field designated for email addresses in the newsletter subscription form is currently using an tag of type text instead of the appropriate type email. This issue impacts the user experience by not providing the necessary validation for email addresses, leading to potential input errors.

Add screenshots

image

Please assign this issue to me. I am a contributor at GSSoC' 24. I would be very happy to work on it.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge, Brave, Other

Record

  • I agree to follow this project's Code of Conduct
  • I want to work on this issue
@PranavKeshav24 PranavKeshav24 added 🛠 goal: fix The label is related to fixing a bug 🪲 bug Something isn't working labels Jun 13, 2024
Copy link

Congratulations, @PranavKeshav24! 🎉 Thank you for creating the issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

'We will promptly review your changes and offer feedback. Keep up the excellent work!
Kindly remember to check our Contributing Guidelines'

@yashd-dev
Copy link

Hi there, could you also include a email regex pattern aswell?

@PranavKeshav24
Copy link
Author

@yashd-dev Sure, I'll do that.

@yashd-dev yashd-dev added BEGINNER Difficulty Level: Beginner gssoc GSSOC'24 Required Label labels Jun 13, 2024
@SuperSahitya
Copy link
Contributor

I have created a PR to fix this issue. Since the input type 'email' already has validations in place, I do not see the need to add another regex pattern for email unless we want to allow specific domains or provide custom warnings for incorrect email input.

Copy link

Hello @PranavKeshav24! Your issue #379 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEGINNER Difficulty Level: Beginner 🪲 bug Something isn't working 🛠 goal: fix The label is related to fixing a bug gssoc GSSOC'24 Required Label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants