-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Text input field for email in newsletter #379
Comments
Congratulations, @PranavKeshav24! 🎉 Thank you for creating the issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work! 'We will promptly review your changes and offer feedback. Keep up the excellent work! |
Hi there, could you also include a email regex pattern aswell? |
@yashd-dev Sure, I'll do that. |
I have created a PR to fix this issue. Since the input type 'email' already has validations in place, I do not see the need to add another regex pattern for email unless we want to allow specific domains or provide custom warnings for incorrect email input. |
Hello @PranavKeshav24! Your issue #379 has been closed. Thank you for your contribution! |
What happened?
The text input field designated for email addresses in the newsletter subscription form is currently using an tag of type text instead of the appropriate type email. This issue impacts the user experience by not providing the necessary validation for email addresses, leading to potential input errors.
Add screenshots
Please assign this issue to me. I am a contributor at GSSoC' 24. I would be very happy to work on it.
What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge, Brave, Other
Record
The text was updated successfully, but these errors were encountered: