Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/backend] Templatize MemoryPlannerFactory in train #13984

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

zetwhite
Copy link
Contributor

This PR templatize memory planner factory in train backend. MemoryPlannerFactory currently used for DisposableTensorIndex, but it will be also used for LayerScopeTensorIndex.

ONE-DCO-1.0-Signed-off-by: seunghui youn [email protected]
draft : #13486
for : #13282

This PR templatize memory planner factory in train backend.
MemoryPlannerFactory currently used for DisposableTensorIndex, but it will be also used for LayerScopeTensorIndex.

ONE-DCO-1.0-Signed-off-by: seunghui youn <[email protected]>
draft : Samsung#13486
for : Samsung#13282
@zetwhite zetwhite marked this pull request as ready for review September 11, 2024 06:46
@zetwhite zetwhite added the PR/ready for review It is ready to review. Please review it. label Sep 11, 2024
@zetwhite zetwhite requested a review from a team September 11, 2024 06:46
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zetwhite zetwhite requested a review from a team September 11, 2024 09:09
return instance;
}

// TODO: Update to use template varialbe instead of DisposableTensorIndex
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves this TODO.
MemoryPlannerFactory will be used for both LayerScopeTensorIdx and DisposableTensorIdx.

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 6c6f88d into Samsung:master Sep 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants