Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luci/pass] Fix pattern match direction to model input #13685

Open
seanshpark opened this issue Aug 18, 2024 · 3 comments
Open

[luci/pass] Fix pattern match direction to model input #13685

seanshpark opened this issue Aug 18, 2024 · 3 comments

Comments

@seanshpark
Copy link
Contributor

Some of our luci/pass pattern search direction is from model input to output.
Technically this is OK for both direction search.
For maintenance and new future pass codes, it is better to maintain one search pattern.

@seanshpark
Copy link
Contributor Author

seanshpark commented Aug 18, 2024

Passes to fix

  • FuseAddWithFullyConnectedPass -> ?
  • FuseAddWithTConvPass -> @jiwaszki
  • ...

@jiwaszki
Copy link
Contributor

@seanshpark here is another pass that might be added to the list:

What do you think?

BTW would you mind assigning me to this issue?

@seanshpark
Copy link
Contributor Author

What do you think?

Fine with me :)

BTW would you mind assigning me to this issue?

Usually here in ONE/compiler, we don't assign someone, but self assigns to some task :)
As you asked, I've updated the list with your ID so you can freely work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants