Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Unify interfaces of TrainableBackendContext #13622

Closed
ragmani opened this issue Aug 8, 2024 · 1 comment
Closed

[onert] Unify interfaces of TrainableBackendContext #13622

ragmani opened this issue Aug 8, 2024 · 1 comment

Comments

@ragmani
Copy link
Contributor

ragmani commented Aug 8, 2024

What

Let's unify interfaces(genTensors, genTrainingTensors, and genKernels) of TrainableBackendContext.

Why

Currently those three functions(genTensors, genTrainingTensors, and genKernels) are called sequentially because the creation of tensors is the prerequisite for generating kernels in most backends and generating kernels has no prerequisite related to generating tensors.
However, we are going to introduce a feature in which generating kernels is the prerequisite for generating tensors in the train backend. That means generating tensors and generating kernels are interdependent on each other. Therefore, the calling priority of those three functions cannot be determined outside the train backend. We need to pass the determination to each training backend instead of onert core.

draft : #13629

@ragmani
Copy link
Contributor Author

ragmani commented Aug 14, 2024

Done.

@ragmani ragmani closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant