From 0d5f1c89fba62f29638186133b486b38e1562547 Mon Sep 17 00:00:00 2001 From: tomdol Date: Thu, 28 Nov 2024 02:29:53 +0100 Subject: [PATCH] [compute/cker] Remove the storage order parametrization from BatchMatMul (#14371) * [compute/cker] Remove the storage order parametrization from BatchMatMul This commit removes the obsolete parametrization of the BatchMatMul x86 optimized kernel. The reason is that the storage order attribute of the MatrixParams class is later ignored by the x86 Gemm implementation using Eigen. ONE-DCO-1.0-Signed-off-by: Tomasz Dolbniak t.dolbniak@partner.samsung.com * Revert the storage order with some comments --- compute/cker/include/cker/operation/optimized/BatchMatMul.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compute/cker/include/cker/operation/optimized/BatchMatMul.h b/compute/cker/include/cker/operation/optimized/BatchMatMul.h index ea1b744fbed..15a46fcce6f 100644 --- a/compute/cker/include/cker/operation/optimized/BatchMatMul.h +++ b/compute/cker/include/cker/operation/optimized/BatchMatMul.h @@ -33,17 +33,17 @@ inline void BatchMatMul(const BatchMatMulParams ¶ms, const float *lhs_data, const float *rhs_data, float *output_data) { MatrixParams lhs_params; - lhs_params.order = Order::kRowMajor; + lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen lhs_params.rows = params.lhs_rows; lhs_params.cols = params.lhs_cols; MatrixParams rhs_params; - rhs_params.order = Order::kRowMajor; + lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen rhs_params.rows = params.rhs_rows; rhs_params.cols = params.rhs_cols; MatrixParams dst_params; - dst_params.order = Order::kRowMajor; + lhs_params.order = Order::kRowMajor; // ignored by GemmImplUsingEigen dst_params.rows = params.lhs_rows; dst_params.cols = params.rhs_cols;