-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always show seekbar tooltip info while dragging #306
Comments
In theory, it is possible, just need to modify the mouse hit to add a condition to it. Lines 1138 to 1143 in 488854b
For example, if we add this before local force_show_tooltip = element.name == "seekbar"
and element.eventresponder["mbtn_left_down"]
and element.state.mbtnleft
and state.mouse_down_counter > 0 Then replace if mouse_hit(element) or force_show_tooltip then Issues:
|
Awesome I can definitely test it out as soon as I can. Let you know if any issues pop up. |
It mostly works well (way better than current behavior) but with a couple glitches like the one you mentioned:
There's another glitch, if you drag the progress bar to the beginning or end of the file, click and drag the maximize button, the thumbnail will show up. mpv_9ca9zhdBFY.mp4 |
🤣 Yeah, most likely because of the mouse click counter. Definitely needs a better implementation than this one, as this just adds way too many global parameters not specific to seekbar. Maybe it should just specifically alter/force show for thumbfast/time tooltips instead of the whole slider element. (ie: |
Expected behavior of the wanted feature
Current behavior
All seekbar information (thumbnail, time stamp, chapter title) disappears unless you're hovering the seek handle.
Desired behavior
Keep all seekbar information prominent even if mouse cursor drifts off the handle while dragging.
The text was updated successfully, but these errors were encountered: