New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom attributes on return types (v31 feature) #351

Open

ds5678 opened this issue Oct 23, 2024 · 1 comment

Contributor

ds5678 commented Oct 23, 2024

Cpp2IL/Cpp2IL.Core/Model/Contexts/MethodAnalysisContext.cs

Line 76 in e454c55

//TODO Support custom attributes on return types (v31 feature)

Contributor Author

ds5678 commented Nov 2, 2024

After investigating this, it seems that this is currently an unfinished feature from Unity.

returnParameterToken is 0x08000000 when there are no custom attributes, which is most of the time.
When there are custom attributes on the Mono return parameter, returnParameterToken is either:
- The last parameter's token plus one. (6000.0.11)
- The first parameter's token minus one. (6000.0.25)
When returnParameterToken is not 0x08000000, the parameter definition with that token is for a different method, ie there's a conflict.

I've pushed my changes into a branch for posterity: https://github.com/ds5678/Cpp2IL/tree/return-parameter-wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment