New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This will shut off dispatches if you press a new key and then release the new ke... #60

Open

todo bot opened this issue Oct 12, 2019 · 0 comments

Labels

todo bot commented Oct 12, 2019

WebReplayViewer/src/managers/KeyManager.ts

Lines 78 to 83 in a5cd501

    
           // TODO: This will shut off dispatches if you press a new key and then release the new key 
        
           // without keyup on the first. Should fix for edge case. 
        
           if (performance.now() - this.lastKeyPress > 2000) { 
        
             this.keysPressed = [] 
        
             return 
        
           }

This issue was generated by todo based on a `TODO` comment in `a5cd501` when #48 was merged. cc @SaltieRL.

The text was updated successfully, but these errors were encountered:

todo bot added the todo 🗒️ label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment