Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload files in separate thread, delete after upload #58

Open
dtracers opened this issue Jan 29, 2018 · 2 comments
Open

upload files in separate thread, delete after upload #58

dtracers opened this issue Jan 29, 2018 · 2 comments
Assignees

Comments

@dtracers
Copy link
Member

dtracers commented Jan 29, 2018

We currently write file data and upload in the same thread as the one the bot logic is running in.

I think we can write the file data in the same thread but uploading the file data needs to happen in a separate thread.


Files that upload successfully should be deleted from the local disk.

@Sciguymjm
Copy link
Member

Due to GIL (global interpreter lock), there is a good chance the file upload will need to be a separate process/script.

@Sciguymjm Sciguymjm changed the title upload files in separate thread. upload files in separate thread, delete after upload Feb 6, 2018
@dtracers
Copy link
Member Author

dtracers commented Feb 6, 2018

spawning a process to handle this should be fairly easy.
Maybe we make the server converter internally maintain its own process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants