Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation table not highlighting warnings properly #518

Open
1 task
afwillia opened this issue Mar 16, 2023 · 0 comments
Open
1 task

Validation table not highlighting warnings properly #518

afwillia opened this issue Mar 16, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@afwillia
Copy link
Contributor

Describe the bug
When validating HTAN DFCI clinical diagnosis lung dataset, there are no errors, but several warnings for invalid int types. These cells should be highlighted in the table, but they are not. This causes the submit button to stay hidden, even though it should pop up when the manifest returns only warnings or no errors.

To Reproduce
Steps to reproduce the behavior:

  1. HTAN DFCI
  2. diagnosis template
  3. clinical_diagnosis_lung dataset
  4. validation manifest in this issue https://sagebionetworks.jira.com/browse/HTAN-163

Expected behavior
The invalid cells should be highlighted and the submit button should show up.

Priority (select one)

  • Major 📢

This commit allows the submit button to show up, but doesn't fix highlighting df5fa54

Investigate why validationResult is not returning a list of cells. For the offending cells, it had character(0) instead of an index of cells to highlight

@afwillia afwillia added the bug Something isn't working label Mar 16, 2023
@afwillia afwillia self-assigned this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant