From 5098c199cce6ba7ddceb4b9bc13f7fd9e525c71c Mon Sep 17 00:00:00 2001
From: Tom Zeller <tzeller@dragonacea.biz>
Date: Wed, 8 Nov 2017 05:37:46 -0600
Subject: [PATCH 1/4] CO-1447 Fix reading results of max order search (#27)

https://bugs.internet2.edu/jira/projects/CO/issues/CO-1447
---
 app/Model/CoProvisioningTarget.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/Model/CoProvisioningTarget.php b/app/Model/CoProvisioningTarget.php
index 1ab0b1744..94dbe16bc 100644
--- a/app/Model/CoProvisioningTarget.php
+++ b/app/Model/CoProvisioningTarget.php
@@ -112,8 +112,8 @@ public function beforeSave($options = array()) {
       
       $o = $this->find('first', $args);
       
-      if(!empty($o['m'])) {
-        $n = $o['m'] + 1;
+      if(!empty($o[0]['m'])) {
+        $n = $o[0]['m'] + 1;
       }
       
       $this->data['CoProvisioningTarget']['ordr'] = $n;

From 9c4a2a7cbc215b87891ac2c18d5c8d4f4bd9404e Mon Sep 17 00:00:00 2001
From: Arlen Johnson <arlen@dogenmedia.com>
Date: Thu, 30 Nov 2017 12:03:36 -0500
Subject: [PATCH 2/4] Fix date picker placement in CO Person Roles (CO-1539)

---
 app/View/CoPersonRoles/fields.inc | 6 +++---
 app/webroot/css/co-base.css       | 4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app/View/CoPersonRoles/fields.inc b/app/View/CoPersonRoles/fields.inc
index b3e8d3033..28ec78680 100644
--- a/app/View/CoPersonRoles/fields.inc
+++ b/app/View/CoPersonRoles/fields.inc
@@ -419,7 +419,7 @@
                 ?>
               </div>
             </li>
-            <li>
+            <li class="modelbox-data">
               <div class="field-name">
                 <?php
                   if($e && !$es) {
@@ -455,7 +455,7 @@
                 ?>
               </div>
             </li>
-            <li>
+            <li class="modelbox-data">
               <div class="field-name">
                 <?php
                   if($e && !$es) {
@@ -501,7 +501,7 @@
               foreach($vv_extended_attributes as $c) {
                 $attr = strtolower($c['CoExtendedAttribute']['name']);
                 ?>
-                <li>
+                <li class="modelbox-data">
                   <div class="field-name">
                     <?php
                       if($e && !$es) {
diff --git a/app/webroot/css/co-base.css b/app/webroot/css/co-base.css
index d82e3d8f2..40d2eaea7 100644
--- a/app/webroot/css/co-base.css
+++ b/app/webroot/css/co-base.css
@@ -1436,6 +1436,10 @@ ul.form-list select {
 ul.form-list li.fields-submit .required {
   font-style: italic;
 }
+ul.form-list li.modelbox-data #ui-datepicker-div {
+  position: relative !important; /* a fix for datepickers appended to fields in the form-list */
+  margin: 0 0 0 9px;
+}
 ul.field-children {
   margin: 0.5em;
   padding: 0;

From 1b5e49fefe307565414851d8a22bef9a82d9fa65 Mon Sep 17 00:00:00 2001
From: Scott Koranda <skoranda@gmail.com>
Date: Thu, 21 Dec 2017 05:54:18 -0600
Subject: [PATCH 3/4] Fix GrouperProvisioner re-provision first provision
 (CO-1580)

---
 .../GrouperProvisioner/Model/CoGrouperProvisionerTarget.php  | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/app/Plugin/GrouperProvisioner/Model/CoGrouperProvisionerTarget.php b/app/Plugin/GrouperProvisioner/Model/CoGrouperProvisionerTarget.php
index 11d23b346..9e3240497 100644
--- a/app/Plugin/GrouperProvisioner/Model/CoGrouperProvisionerTarget.php
+++ b/app/Plugin/GrouperProvisioner/Model/CoGrouperProvisionerTarget.php
@@ -486,6 +486,11 @@ public function provisionCoGroupDeleted($coProvisioningTargetData, $coGroup) {
 
   public function provisionCoGroupReprovisionRequested($coProvisioningTargetData, $coGroup) {
     $provisionerGroup = $this->CoGrouperProvisionerGroup->findProvisionerGroup($coProvisioningTargetData, $coGroup);
+
+    if(!isset($provisionerGroup)) {
+      $provisionerGroup = $this->CoGrouperProvisionerGroup->addProvisionerGroup($coProvisioningTargetData, $coGroup);
+    } 
+
     $groupName = $this->CoGrouperProvisionerGroup->getGrouperGroupName($provisionerGroup);
     $groupDescription = $this->CoGrouperProvisionerGroup->getGrouperGroupDescription($provisionerGroup);
     $groupDisplayExtension = $this->CoGrouperProvisionerGroup->getGroupDisplayExtension($provisionerGroup);

From 4ab3e118619ab9d695be628156f25ae227100f72 Mon Sep 17 00:00:00 2001
From: Arlen Johnson <arlen@dogenmedia.com>
Date: Fri, 22 Dec 2017 09:32:21 -0500
Subject: [PATCH 4/4] Fix date picker placement in OrgIdentities and
 CoEnrollmentAttributes (CO-1539)

---
 app/View/CoEnrollmentAttributes/fields.inc | 2 +-
 app/View/OrgIdentities/fields.inc          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/View/CoEnrollmentAttributes/fields.inc b/app/View/CoEnrollmentAttributes/fields.inc
index 8a2d4fdcb..0efa9539f 100644
--- a/app/View/CoEnrollmentAttributes/fields.inc
+++ b/app/View/CoEnrollmentAttributes/fields.inc
@@ -522,7 +522,7 @@
               </select>
             <?php endif; ?>
           </div>
-          <div id="attr_def_val_date_div">
+          <div id="attr_def_val_date_div" class="modelbox-data">
             <?php if($e): ?>
               <input name="def_date_type"
                      id="def_date_fixed"
diff --git a/app/View/OrgIdentities/fields.inc b/app/View/OrgIdentities/fields.inc
index b4b52ee02..489264513 100644
--- a/app/View/OrgIdentities/fields.inc
+++ b/app/View/OrgIdentities/fields.inc
@@ -456,7 +456,7 @@
               ?>
             </div>
           </li>
-          <li>
+          <li class="modelbox-data">
             <div class="field-name">
               <?php
                 if($e) {
@@ -496,7 +496,7 @@
               ?>
             </div>
           </li>
-          <li>
+          <li class="modelbox-data">
             <div class="field-name">
               <?php
                 if($e) {